Feat/1767 error boundary stack trace (#1772)
* feat: ErrorBoundary collapsed stack trace * button styles * Change "Toggle stack trace" to "Stack Trace" Co-authored-by: James Petts <jamesapetts@gmail.com>
This commit is contained in:
parent
4293c073f0
commit
950a54c704
@ -51,3 +51,9 @@ button.close
|
||||
position: relative;
|
||||
display: inline-block;
|
||||
vertical-align: middle;
|
||||
|
||||
.btn-sm
|
||||
padding: .25rem .5rem;
|
||||
font-size: .875rem;
|
||||
line-height: 1.5;
|
||||
border-radius: .2rem;
|
||||
|
||||
@ -0,0 +1,18 @@
|
||||
.ErrorBoundaryDialogTitle {
|
||||
margin-top: 0;
|
||||
}
|
||||
|
||||
.ErrorBoundaryDialogButton {
|
||||
outline: none;
|
||||
}
|
||||
|
||||
.ErrorBoundaryDialogIcon {
|
||||
margin-right: 5px;
|
||||
width: 10px;
|
||||
transform: rotate(-90deg);
|
||||
vertical-align: middle;
|
||||
}
|
||||
|
||||
.ErrorBoundaryDialogIcon.opened {
|
||||
transform: rotate(0deg);
|
||||
}
|
||||
@ -1,26 +1,46 @@
|
||||
import React from 'react';
|
||||
import React, { useState } from 'react';
|
||||
import classnames from 'classnames';
|
||||
import PropTypes from 'prop-types';
|
||||
import { ErrorBoundary } from '@ohif/ui';
|
||||
import { ErrorBoundary, Icon } from '@ohif/ui';
|
||||
import { servicesManager } from './../../App';
|
||||
|
||||
import './ErrorBoundaryDialog.css';
|
||||
|
||||
const { UIModalService } = servicesManager.services;
|
||||
|
||||
const ErrorBoundaryDialog = ({ context, children }) => {
|
||||
const handleOnError = (error, componentStack) => {
|
||||
const ErrorDialog = () => (
|
||||
<div className="ErrorFallback" role="alert">
|
||||
<div>
|
||||
<h3>
|
||||
{context}: <span>{error.message}</span>
|
||||
</h3>
|
||||
const ErrorDialog = () => {
|
||||
const [open, setOpen] = useState(false);
|
||||
|
||||
return (
|
||||
<div className="ErrorFallback" role="alert">
|
||||
<div className="ErrorBoundaryDialog">
|
||||
<h3 className="ErrorBoundaryDialogTitle">
|
||||
{context}: <span>{error.message}</span>
|
||||
</h3>
|
||||
</div>
|
||||
<button
|
||||
className="btn btn-primary btn-sm ErrorBoundaryDialogButton"
|
||||
onClick={() => setOpen(s => !s)}
|
||||
>
|
||||
<Icon
|
||||
name="chevron-down"
|
||||
className={classnames('ErrorBoundaryDialogIcon', {
|
||||
opened: open,
|
||||
})}
|
||||
/>
|
||||
Stack Trace
|
||||
</button>
|
||||
|
||||
{open && <pre>{componentStack}</pre>}
|
||||
</div>
|
||||
<pre>{componentStack}</pre>
|
||||
</div>
|
||||
);
|
||||
);
|
||||
};
|
||||
|
||||
UIModalService.show({
|
||||
content: ErrorDialog,
|
||||
title: `${context}: ${error.message}`,
|
||||
title: `Something went wrong in ${context}`,
|
||||
});
|
||||
};
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user