TrizTech/ohif-viewer
15
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add netlify documentation to contributing.md

Browse Source 
This is a sort of meta-PR in the sense that it's a real PR to add this documentation, and also a test to confirm that this PR will trigger a netlify build of the documentation that can be used to confirm that the link will work.
This commit is contained in:
Steve Pieper 2018-07-23 17:29:22 -04:00 committed by GitHub
parent aca17e4d38
commit eea430f2e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
docs/contributing.md
View File

@ -14,3 +14,14 @@ While we do appreciate code contributions, triaging and integrating contributed
- The scope of the pull request is not too large. Please consider separate pull requests for each feature as big pull requests are very time consuming to understand.
We will provide feedback on your pull requests as soon as possible. Following the tips above will help ensure your changes are reviewed.
### Testing contribution pull requests
OHIF uses [netlify](netlify.com) so that pull requests are autogenerated and available for testing.
For example, [this url](https://deploy-preview-235--ohif.netlify.com/viewer/?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/sampleDICOM.json) allows you to test [pull request 235](https://github.com/OHIF/Viewers/pull/235) using data pulled from Amazon S3.
Replacing the number 235 in the link below with your pull request number should let you test it as well and you can use this link for discussions on github without requiring reviewers to download and build your branch.
```
https://deploy-preview-235--ohif.netlify.com/viewer/?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/sampleDICOM.json
```