othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix importStudies dialog when import fails (#223)

Browse Source 
If an import happens to fail the dialog promise never resolves. 

This is because `numberOfStudiesFailed` is incremented on error but `numberOfStudiesImported` is not, so the branch  to resolve or reject is never taken.
This commit is contained in:
frmdstryr 2018-07-13 09:38:15 -04:00 committed by Erik Ziegler
parent 37ef5dc3df
commit 7849699a0d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Packages/ohif-study-list/client/lib/importStudies.js
View File

@ -104,7 +104,7 @@ const importStudiesInternal = (studiesToImport, dialog) => {
const { numberOfStudiesImported, numberOfStudiesFailed } = studyImportStatus;
dialog.update(numberOfStudiesImported);
if (numberOfStudiesImported === numberOfStudies) {
if ((numberOfStudiesImported + numberOfStudiesFailed) === numberOfStudies) {
// The entire import operation is completed, so remove the study import status item
Meteor.call('removeStudyImportStatus', studyImportStatus._id);