ohif-viewer/maintainer-notes.md
Danny Brown 49d343941e
fix: measurementsAPI issue caused by production build (#842)
* ci: test docs-publish

* Specify to use prod

* Babel should transpile with env set by webpack

* in-progress

* in-progress

* Polyfill for ie11 and edge features

* Ditch polyfills w/ babel - we'll use a service for now

* Bump tools version; shift vtk.js up a layer

* Specify we shouldn't target older than IE 11

* ditch babel plugins that should be covered by preset-env

* Add a top level build demo command

* Let our babel config determine settings

* Same babel fixes as PWA

* Rebuild deps that don't satisfy our target

* Mini helper script for excluding all node_modules, except...

* Shift vtk.js dep up a layer

* Kill core-js

* Export in a node happy way

* Updated yarn lock

* Set NODE_ENV when launching anything w/ WebPack

* docs: updated FAQ

* docs: on browser support

* Add support for redux browser extension

* misc. small clean-up

* docs: Remove roadmap page; add browser-support to sidebar

* Formatting

* Remove roadmap links

* Formatting

* ci: Remove config syntax error

* Simplified bug report template

* update community request template

* Update question's template

* simplify build scripts

* specify new script names

* fix: for measurement api being pruned by minimizer in prod builds

* Use named exports

* Simplify config

* Let's not do so much heavy lifting for a dev-server build

* fix dev build

* Add hotkeys to demo

* fix: jest babel config and env specific configs

* Remove call to non-existant command

* Shift experimental proposal plugin up a layer

* Use `https`

* Try with reduced number of package exceptions

* Try to resolve cypress issue

* Try to fix cypress issue in CI

* Skip https
2019-09-04 13:53:13 -04:00

1.7 KiB

Notes

Helpful Commands

These commands are less frequently used, but good to remember:

# Add shared dev dependency for workspace
yarn add --dev -W package-name

TODO

  • Patch status for PRs (we care about threshold only)
    • Allows us to use multiproject test runner
  • Flags per project for merged coverage; easier to break down coverage per project
  • Remove all-contributors bot; install CLI per project and add per project commands
  • Fix broken peer dependencies?

ORBS

Debug Note: http://localhost:3000/webpack-dev-server

Bundling

  • Extensions must bundle all assets into a single file for UMD
  • The umd build for Viewer must bundle all of it's assets, and baked-in extension assets
    • The "skinny" umd build for viewer only needs to bundle it's own assets
  • The PWA build for Viewer can code-split to it's heart's content
  • Don't load/bundle a font at any layer other than Application/Viewer
  • It gets to decide if it should be bundled/cached/external
  • For ESM/Module builds
  • Not dissimilar from VTK.js consumption
  • jest --watchAll for individual packages?

WebPack 5: https://github.com/webpack/webpack/issues/6386#issue-291757876

Flattened ESM: Less efficient, not as great at code splitting? From source? More loaders, added complexity, slower builds, better output

Notes:

  • Remove preBuild step in viewer after @3 wado image loader