othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
d92fe44d3c
ohif-viewer/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Danny Brown 862d426c71
ci: first attempt at adding a gated docker PR Publish (#1038) (#1041) 
* ci: first attempt at adding a gated docker PR Publish (#1038)

* ci: first attempt at adding a gated docker PR Publish

* See if we can use contexts to inject variables after approval

* fix build command

* try alternative context

* docs: pull request template that spells out PR checklist

* change context back to Docker Hub

* Switch optional approval to another workflow

* Make docker builds faster

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
2019-10-22 15:53:44 -04:00

917 B
Raw Blame History

Request Checklist

  • [] Brief description of changes
  • [] Links to any relevant issues
  • [] Required status checks are passing
  • [] @mention a maintainer to request a review

Special

If this PR is not on a branch for this repo, it is "untrusted" and does not have access to env vars. Reviewers can kick off a trusted docker deploy by:

  1. Verifying there are no malicious changes to CI build
  2. Using the git-push-fork-to-upstream-branch script
  3. Executing the manual approval step in the CI workflow
  • [] Request docker publish of PR

Want to improve this process? Consider PR'ing the ability for reviewers to add a label to trigger this process.