Add the ability to merge two different series queries to generate a complete study query result. Provides basic support for other types of merges, but those aren't yet added as full features.
This change makes the OHIF side consistent with the CS3D user calibration settings, and will correctly display px and rounding values consistent with the CS3D display.
There are a couple of changes here which should improve stability of the tests. Hopefully that will be sufficient, but it is difficult to tell for sure if it is complete.
* fix bugs for the RT for the new demo
* fix SM with the static-wado server
* remove thumbnail from tmtv
* migration guide
* fix stability for the rt struct
* apply review comments
* add loading indicator to SM
* pdf works
* try to fix relative bulkData
* fix the rest
* fix preflight for the SM
* fix typo
* apply review comments
* yarn lock
* fix(DicomTagBrowser): Fix parsing problems that was limiting nested tags rendering
* Added a progress indicator when switching to a list of more than 1000 rows.
* Switched to using react-window to virtualize the dicom tag browser window.
* Added filtering to the DICOM tag browser with a new search UI widget.
Lots of tweaks and updates to the look-and-feel.
* Removed unused import.
* PR feedback including some UI tweaks.
* More PR feedback.
---------
Co-authored-by: Igor Octaviano <igor.octaviano@radicalimaging.com>
Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>
* fix(command): Added command and hotkey binding for navigate to next and previous display set.
* Centralized the sorting (function) of display sets since at least three
areas sort display sets: hanging protocols, study/thumbnail browser and
updateViewportDisplaySet command.
* Renamed some methods for clarity.
* Scrolling active thumbnail into view for an updateViewportDisplaySet
* Added a null check.
* Added check to minimize thumbnail scrolling.
* fix(Measurement): fixed line dashing of measurements in various scenarios
For a StackViewport simply rely on the SeriesInstanceUID being part of the
tracked measurements or not.
For a VolumeViewport first check the image id of the current image in the viewport
and then check the SeriesInstanceUID (like for a StackViewport) if an id is returned.
To reliably get the id of the current image, listen for the VOLUME_VIEWPORT_NEW_VOLUME event.
* Changes for PR comments.
* fix(Video): Added fallback checks for DICOM video
Added some docs for video, pdf and upload.
* Added separate headings for DICOM PDF, DICOM Video and DICOM Upload in the docs.
* Updated docs for singlepart data source configuration.
* fix(local): should use dicomlocal for localbasic
* chore(github): styling for issues forms
* try to fix netlify
* apply review comments
* apply review comments
- prevent non-cornerstone viewports from showing the image download dialogue
- passing the rendering engine id to ToolGroup.addViewport
- fixed the keep/dismiss aspect feature
* feat(custom displayOptions): add custom options to every level of hanging protocols
* move set preset down to cornerstone3d
* works
* fix tmtv based on new api
* fix unit test
* close
* review1
* upgrade packages
* update packages
* apply review comments
* recursive call
* less copy
* apply review comments
* fix e2e tests
* apply review comments
* revert
* apply review comments
* apply review comments
---------
Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
* fix(dicomlocal): navigate /local to the work list and /localbasic to the (basic) viewer
For TMTV, consider both the forward and back slash separator for modalities.
* Fix to TMTV isValidMode method.
* PR feedback:
- replace forward slashes with back slashes for modalities in the WorkList instead of in the Mode.
* Added query.series to DicomLocalDataSource.
* fix: KO series being displayed in browser list
* fix sr for volume viewports
* move highlight labelmap to RAF
* remove commented code
* fix the hydration bug for the SR
* apply review comments
* revert the key images for sr
* Remove some obsolete changes
* set initial image for sr instead of jump
* Remove viewportType stack
---------
Co-authored-by: Alireza <ar.sedghi@gmail.com>
* fix(Measurements): return {} instead of undefined for getSOPInstanceAttributes
* PR feedback:
- separated measurements from non-acquisition plane
- reverted to previous behaviour of returning undefined in getSOPInstanceAttributes
* Added unit tests for unmapped measurements.
* PR feedback: added comments to the unmappedMeasurement used in the unit tests.
* fix: multiframe
* fix the unnecessary use of prior since some servers dont like it
* add authentication via token in url
* add data citation
* add resources
* upgrade packages
* yarn lock
* apply review comments
Update HangingProtocolService doc to include example and instructions to use custom attributes included in @ohif/extension-test. Example shows usage of sameAs for frame of reference check in tmtv hanging protocol.
* fix(DICOM PDF and Video)
- added retrieve.directURL for local DICOM load data source; it returns a data URL
- fixed various checks for video using transfer syntaxes and SOP class UID with number of frames
- added call to 'rendered' endpoint for those data sources that support it; others get BulkDataURI
* Added DOC (PDF) and OT (for video in particular) to list of non-image thumbnail modalities.
* Fixed broken e2e tests.
* choe(modes, components): improved readability
This commit includes changes to improve performance in the basic-dev-mode and Thumbnail components.
Additionally, a change in the webpack configuration file was made to ignore ".min.js.map" files.
The defaultDataSourceName was also added to several configuration files, and whiteLabeling code was removed
from the local_orthanc configuration file.
* fix(cli): better path management and add dependencies
* better docs
* add default tool group to the templates
* add review comments
* apply review comments
* try to fix test
* fix thumbnail in tests
The description for the numberOfDisplaySetsWithImages property was corrected. The update also involves adding a callback property that returns several objects (matchedViewports, viewportMatchDetails, displaySetMatchDetails) and returning them from the method 'findViewportProtocols'. The refactored code also has better readability.
* fix: Jump to measurement after presentation store
* Fix initial load of DICOM SR
* Fix measurement highlight issues
* Clear measurements changed to array
* Fix merge issues
* PR comments
* Removed unused formatting. Change to single event
* Fix the unit test
* PR review comments
* refactor(viewport): simplify imports, align destructuring
Simplify import statements by removing unused imports, organize existing imports, and align destructured imports consistently across the component.
---------
* feat(DICOM Upload)
OHIF #3297
- DicomWebDataSource.store.dicom now accepts an ArrayBuffer of data sets to store
- DicomWebDataSource.store.dicom now also accepts optional callbacks to track upload and an AbortSignal object to cancel upload
- Added DicomFileUploader class that performs and tracks the upload of a DICOM file
- Added various UI pieces for the upload: DicomUpload, DicomUploadProgress, DicomUploadProgressItem
- ProgressLoadingBar was extracted from LoadingIndicatorProgress so it can be reused
- Modal dialogues can now optionally prevent an outside click from closing the Modal
* Passing an XMLHttpRequest to the dataSource.store.dicom method instead of callbacks and AbortSignal.
Cleanup of various UI pieces to minimize code and increase readability.
* Made the DicomUpload component a customization module exported by the cornerstone extension.
* Exposed a copy of the data source configuration via the IWebApiDataSource interface.
Added dicomUploadEnabled to a data source's configuration.
* Code clean up.
* Upgraded the dicomweb-client version to one that provides the ability to
pass a custom HTTP request. DICOM upload uses that custom HTTP request
to track progress and cancel requests.
* Distinguished between failed and cancelled uploads.
* Allow no selection in the upload dialogue.
Fixed the styling of various progress information so that everything aligns.
* Switched from cornerstone wado image loader to cornerstone dicom image loader for DICOM upload.
* Added special cancelled icon to differentiate from failed.
* Added a bit of spacing between the upload progress bar and percentage.
* Fixed minor issue with upload rejection.
* Performance improvement for cancel all uploads:
- use React memo for each upload item progress (row)
- do not await each request of a cancel all
* Fixed various padding/spacing for the DICOM upload drop zone component.
Changed the border dashing for the DICOM upload drop zone to be a background image gradient.
Added hover and active effects to the 'Cancel All Uploads' text.
* fix: viewportdialoge not appearing in non-tracked viewports
* feat(viewports): Introduce useViewportDialog and remove deprecated API
This commit introduces the `useViewportDialog` hook and replaces the deprecated `viewportDialogApi` with the new `viewportDialogState`. Additionally, the notifications in `OHIFCornerstoneRTViewport` and `OHIFCornerstoneViewport` have been removed. Finally, the `CinePlayer` component now accepts optional parameters.
* fix tests
* feat(cst): Add new command to get nearby annotation tools
This commit adds a new command `getNearbyAnnotation` to the `commandsModule.ts` file that identifies nearby annotation tools excluding Crosshairs and ReferenceLines. It also removes an unused mapping to `Crosshairs` in `initMeasurementService.js` and changes the command run in `findNearbyToolData.ts` to `getNearbyAnnotation`.
* perf(cornerstone): Improve performance by optimizing tools
Removes unnecessary imports to improve app's performance. Changes how annotations are detected on the `commandsModule.js` file by fetching the `isAnnotation` property of the tool instance if available. Updates `CrosshairsTool` and `ReferenceLinesTool` to not be annotations anymore. Adjusts the `localhost` URL ports for the `dcm4chee-arc` service interface on `local_dcm4chee.js` to allow for more efficient server communication.
* feat(cornerstone): Add CornerstoneServices type and ToolGroupService.getToolGroup to get tool group by ID or active viewport
This commit introduces the new CornerstoneServices interface to the code and adds the ToolGroupService.getToolGroup method, which can retrieve a specific tool group by ID or from the active viewport. The older _getToolGroup method has also been removed from commandsModule. When no tool group ID is provided, this method now retrieves the tool group from the currently active viewport with the help of getActiveViewportEnabledElement. Additionally, the required reference to @ohif/core has been removed.
* feat(storybook): Refactor Storybook to use Typescript
This commit updates the Storybook configuration to use Typescript, including renaming `main.js` to `main.ts`, updating `core.builder` and `framework.name` to use `@storybook/builder-webpack5` and `@storybook/react-webpack5`, respectively. The code also adds options to `addon-docs` to enable adding GFM support to the generated docs. Additionally, the commit modifies `staticDir`, removes outdated addons, and makes various devDependencies and PostCSS updates to align with Storybook 7.x.x. Finally, the commit removes some unused code and relocates `Button` and `AboutModal` story files.
* apply review comments
* update yarn lock
* fix(Browser history):
- fixed an NPE when navigating to a different study via the URL
- exposed browser history navigation via a command
* Added documentation for the navigateHistory command.
Moved the history object from UI to viewer.
* feat: initial RT support
* make the segmentation service work with representation data
* feat: make segmentation service work with representations
* fix rtss vis
* fix: rt hydration
* fix the rendering of rt names
* fix imports
* refactor: Modify status and click handling for hydration of RTStructures
Modify status and click handling for hydration of RTStructures by renaming `onPillClick` to `onStatusClick` in `OHIFCornerstoneRTViewport.tsx` and `_getStatusComponent.tsx` files. Also, update initial segmentation configurations in `PanelSegmentation.tsx` and simplify configuration changes and values for segmentation service in `SegmentationService.ts`. Finally, remove console debug in `CornerstoneViewportService.ts`.
* wip for highlighting contours
* refactor rt displayset code
* review code update
* update cornerstone dependencies
* refactor: Update license year, version number, and minor code cleanup
This commit updates the license year in several files, updates the version number in package.json, and contains minor code cleanup in two files.
* add bulkdataURI retrieve for RT
* fix package version
* apply review comments
* apply review comments
* apply review comments
* feat(panels): refactor and streamline segmentation configuration and inputs
Rewrote state hooks and streamlined the configuration input for `PanelSegmentation` to be more verbose and reusable. Included several new input types, including the `InputRange` component which now shows a fixed floating value based on the step provided. The `SegmentationConfig` component now works with dynamic values controlled by `initialConfig`. These changes should improve function usability and make the code more maintainable going forward.
* fix various bugs
* fix contour delete by upgrade cs3d version
* feat(viewport, inputNumber, segmentationConfig, orthanc): Implement minimum and maximum values for input number components, and useBulkDataURI for Orthanc configuration. Compare measurement view planes with absolute viewport view planes in Cornerstone viewport.
* update yarn lock
* fix: Make the cornerstone sR viewport show all measurements
* PR fixes
* PR fixes
* Add a DICOM SR hanging protocol
* Duplicate the hanging protocol for seg as well
* PR requested change
* PR requested changes
* PR fixes plus merge update fixes
* PR fixes and integration test fix
* PR - documentation
* feat: Add a new hanging protocol @ohif/mn
* Add @ohif/seg example
* PR comments and a couple more fixes to make things cleaner
* PR comment
* Added an example to cause the PR checks to rerun
* Use more consistent type/structure for services
* Fix restoring SR so the tests described work
* One more typed service
* Added types for the Cornerstone library
* Couple more type fixes
The sameAs function requires displaySetMatchDetails and displaySets to compare attributes between display sets, but these properties were not being passed into the options object. This commit adds the necessary lines of code to include displaySetMatchDetails and displaySets in the options object, fixing the issue where the custom attribute function 'sameAs' was missing required data.
* feat: Allow navigating to a specified series and sop instance
This was a feature in OHIF v2, so adding it to v3, albeit with new
parameters.
feat: Allow comma separated as well as repeated args params
* docs
* Test fixes
* feat: Navigate to SOP selected - PR fixes
* Updated docs
* PR fixes
* fix: The display of linked viewports during drag and drop has a race
* PR review comments
* fix: Segmentation display two up
* Removing console logs
* Fix the blank viewport can have stuff added to it
* Fix the null name on HP module
* Fix the navigate to initial image
* Fix the nth interleave loader
* Fix the unit tests
* PR comments - docs mostly
* fix: Exception thrown on change displayset after double click
* feat(DoubleClick): double click a viewport to one up and back
Added a toggleOneUp command that puts the active viewport into a 1x1 grid layout
and it toggles out of 'one-up' by restoring its saved 'toggleOneUpViewportGridStore'
from the StateSyncService.
Added double click customization for the Cornerstone extension with the
default double click handling being the toggleOneUp command.
Added a cypress test for the double click functionality.
* PR feedback:
- tracked viewport measurements no longer show as dashed when toggling one up
- disallowed double clicking near a measurement
- updated cornerstone3D dependencies to fix double click of TMTV and volume viewport 3D
- created ViewportGridService.getLayoutOptionsFromState
* Updated the ViewportGridService docs.
* Switched to using 'cornerstoneViewportClickCommands' and consistency with the context menu clicks.
* feat: Allow customizing the measurements panel.
Also includes default display of the site/finding values from the DICOM
SR object.
Update fixes
PR review comments - move the recordInteraction to COmmandsManager.run
PR fixes
fix: Dependency updates to allow right click to be recognized
PR fixes
* Use newer CSWIL
* Make both the base measurements and the tracking measurements show codes
* Fix the right click context menu bringing up menu
* feat: Context menu
feat: Custom context menu
Adding documentation
PR updates
* fix: Capture tool exception
* PR updates
* Add fully worked out examples in the basic test mode/extension
* Fix the menu display
* fix: Make the commands on clicks much more configurable
* Wait for load before double clicking
* docs
* PR changes - nothing functional, just moving things endlessly
* PR comments
* PR changes - rename the default context menu
* Renamed the cornerstoneContextMenu to measurementsContextMenu
* Add chevron right to the sub-menus
* fix: Some residual issues with hanging protocol after state sync
fix: Some issues introduced by the state syncing changes
* fix: PR fixes, mostly code cleanup
* Improve a race condition in an automated test
* Remove obsolete code
* PR fixes
* feat: Add state sync and use it to remember viewport grid info
fix: Version updates
Fixes for toggling MPR mode
Fix the display when the interleaved load module fails
Fix the memory of the state to restore correctly
PR fixes for the state sync service
PR fixes
PR fixes
PR fixes
Added a hack warning to remove volumeDeactivate
Fixes for TMTV colormap setting
Fix the casing
Missed renames
fix: tests not running due to variance in ordering
Reverting some fixes to change case
PR changes - mostly comments and minor improvements
fix: All display sets were being updated on drag and drop
PR fixes - mostly renames
PR fixes
Test support for OHIF, for HP branch
test: Add at least a minimal set of automated tests for hanging protocols
Docs
PR fixes
Merge fixes
DOCS updates
Add an example of the mn hanging protocol
PR fixes
PR fixes
PR fixes
* Fix the drag and drop
PR fixes
* PR changes - update default keys for next/previous stage
* fix: Was storing the custom viewport grid too aggressively
Caused by a PR change misspelling a variable
* feat(SidePanel)
OHIF issue #3135
- Added a method to set a callback for a Panel to invoke when it is ready
to be shown (e.g. its data is loaded).
- Implemented such methods for both the segmentation and measurement panels.
- The SidePanel component now adds a callback to Panel components so that
it will automatically open a Panel that was initially closed and yet to
be opened.
- Updated the OHIF documentation accordingly.
* PR feedback
- added a PanelService that centralized much of the logic that existed in panel PanelModule
- the SidePanel subscribes to PanelService.EVENTS.ACTIVATE_PANEL for each of its child panels
* Removed the PanelMeasurementTableTracking setMeasurementPanelContentReadyCallback method.
* Made the forceActive flag in the PanelService optional and defaulted it to false.
* Fixed failing top level exports unit test.
* - PanelService subscriptions are now per panel (id) so subscribers do not
necessarily need to check the panel id in the event when it is fired
- PanelService activate panel trigger subscriptions are now returned
so that they can be (better) managed outside of the service
- updated/created the various documentation for panels and PanelService
* Clarified various documentation.
Moved the code to add the activate panel triggers out of the extensions
and into the longitudinal mode.
* Removed the openWhenPanelActivated flag.
PanelService now conforms to extending PubSubService like the other services.
Updated various documentation.
* Fixed failing e2e, mpr test.
* Renamed the ActivatePanelTriggers type properties.
The ExtensionManager now sets the id of various modules as a property on each of those modules.
* overlay customization
* custom overlay definition and examples
* minor fix - import statement difference between cornerstone and cornerstone3D
* move "VOI" and "Zoom" calulation to the ViewportOverlay component, make OverlayItem fairly dull
* type specifications
* follow up fixes for CustomizationService changes on upstream
* [fix] various fixes related to custom overlays (formatting, toggling)
* [fix] various fixes related to custom overlays (formatting, toggling)
* right side overlay panels - align right
* [fix] remove "notification" from toggleOverlay command
* comments
* [refactor] remove unused imports
* documentation of customizable overlay configuration
* prettify
* review of documentation of customization service
* fix useCallback() dependencies
* fix useCallback dependencies
* documentation for customization service
* documentation for customization service
* Add CT volume in PET ROI Thresholding (#3053)
* Add CT volume in PET ROI Thresholding
* Change UI ROI Threshold config
* Refactoring ROI Threshold configuration Panel
* fix menus
* try to fix build preview
* try to fix build preview
---------
Co-authored-by: rodrigobasilio2022 <114958722+rodrigobasilio2022@users.noreply.github.com>
* feat(ViewportActionBar): OHIF issue #3123 (#3186)
* feat(ViewportActionBar): OHIF issue #3123
- Renamed previous viewport action bar to be LegacyViewportActionBar
- Components LegacyViewportActionBar depends on also renamed: LegacyCinePlayer and LegacyPatientInfo
- New Viewport coded to specs in issue
- added React hook useResizeObserver
- added some tailwind classes
* Updated tailwind to 3.2.7.
Put external imports like React at the top of the import list.
* feat(CinePlayer and ViewportActionBar) (#3198)
* feat(CinePlayer and ViewportActionBar)
- OHIF issue 3123
- new look cine control implemented
- new custom blue color in tailwind config for various hover backgrounds in the cine control
- new icons added for cine
- Tooltip component now can be placed top (center) on hover
- Tooltip component border colour now consistent with specs
- fixed NPE in ViewportActionBar
- upgraded tailwind to 3.2.7 in platform/ui
- fixed issues in various button components brought by tailwind 3.2.7 where classes now need important flag
- fixed issue with InputRange component so that the tracked value property can change externally
- InputRange component can now optionally show its label
- added new measurement tracking state service to hydrate SR without prompting
- segmentation can also now be hydrated without prompting
* PR feedback:
- cine centralized to OHIFCornerstoneViewport
- introduced a type for the CinePlayer properties
* Addressed PR comments and concerns...
The DOM ref for the root component of the ViewportActionBar is now added to state
so that the various callbacks and ResizeObserver are updated with it.
The CinePlayer FPS slider tooltip was moved up so that its arrow does not
intersect the FPS text.
The hover area for the CinePlayer slider tooltip is now the FPS < > buttons and text.
The tracked measurements are now filtered to only include those of the active
viewport series when the tracked measurement navigation arrows are used.
* Addressed PR comments...
The update to tailwind 3.2.7 caused several look-and-feel, UI regressions,
so we are rolling back to 3.2.4.
* tests: add various e2e tests for MPR and measurements
wip
add cypress config
feat: add mode and extension for testing
add hp applied through search params
add MPR tests
apply review comments
add more e2e tests
update yarn lock
* fix unit tests failing
- formatPN should accept a string person name as well as an object with a Alphabetic field.
- For DICOM JSON data sources, spread in the patient data from the study object into the instance.
* fix(ViewportGrid): In ViewportGrid, fill blank viewports with display sets not yet in grid.
ViewportGridService now allows off-screen viewports to remain so that
so as to maintain continuity if they were filled by the UI/user.
* PR feedback: moved getNumViewportPanes into the ViewportGridService API.
* PR feedback:
- renamed some variables
- proper import/export of IDisplaySet
- added some comments for clarification
- fixed broken e2e tests
* Some missed rename of Services.
* fix(misc):Update the data source name, provide a /datasources
Update the imports for a few things to match, to avoid 2 versions
Fix the datasources name
pr:Make the data source selector configurable
* Updated data source selector page as requested
* PR fixes
* fix: OHIF-433 Clicking on measurement should highlight the measurement row in the measurement panel
Added selected flag to each OHIF measurement.
Listening to CS3D ANNOTATION_SELECTION_CHANGE to keep the selected flag in sync.
* fix: OHIF-433 Clicking on measurement should highlight the measurement row in the measurement panel
Fixed broken unit tests.
* PR feedback from Alireza:
- use MEASUREMENT_UPDATED event for selection changed
- added TODO to eventually have CS3D introduce the selected flag per annotation
- added MeasurementService._publishEvent
* PR feedback: now using _broadcastEvent
* fix: app-config settings are ignored in OHIF v3
github issue #3051
Remove default route from baked in routes if showStudyList is false.
* fix: app-config settings are ignored in OHIF v3
github issue #3051
PR feedback - simply remove default route from the baked in routes.
* fix: app-config settings are ignored in OHIF v3
github issue #3051
PR feedback - updated CS3D tools version
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
The primary button will always be the layout grid selector and the MPR toggle is in the drop down menu.
This is the first step to later adding other (e.g. 3D) layout HPs to the menu.
Summary of changes/fixes:
- SplitButton now allows for its primary button to be any button component specified by a UI type.
- SplitButton passes a className to its primary button component to dictate how it should be rendered
based on its active/toggle status, hovering, menu visibility etc.
- The default menu item renderer for the SplitButton, renders acitve toggle items correctly.
- Items/buttons in the toolbar are now all the correct and same size.
- Added ToolbarService.getButtonComponentForUIType to fetch a button component for a given UI type.
- Spacing between toolbar items is now done at the Toolbar level to avoid double spacing and to ensure
uniform spacing.
- The drop down menu closes when clicking the primary button.
- Show a mouse down click effect when clicking the primary button.
Items to investigate still:
The following are all slightly contrary to the design specs of the UI:
- Is the click effect on the primary button satisfactory because with the hover border effect, the
button appears slightly smaller during the mouse down/up operation? (MEDIUM)
- On hover over the drop down button, the right-hand-side corners of the primary button appear
rounded and NOT square. Also the hover over the drop down button border effects make the primary
button appear smaller. (MEDIUM)
- Should there be hover effects when hovering over either tooltip of the SplitButton? (LOW)
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
Fixed broken e2e tests.
data-cy and data-tool properties now passed down to primary button component.
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
On drop down button hover, the primary button now stretches all the way right with no right border
and with square corners in the top and bottom right as per the toolbar spec.
The mouse down effect gives a full button look (i.e. no borders) with rounded corners all around and black text icon.
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
Documented that the primary button of a split button can specify a UI type.
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
Feedback from PR review to fix prettier formatting issue.
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
Added TODOs as per Bill's request in the PR.
* feat: Combine the layout grid selector tool with the toggle MPR button into a split button.
Feedback from Alireza: reverted the layout selector and MPR tools to be separate toolbar items.
Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>
* feat(imageLoader):Add an nth image loader strategy (#10)
* Updates for PR for nth menu
* performance:Prior implementation was O(n^2), taking about 50 ms
* feat:Nth image loader, added docs as requested
* fix: Use single quotes instead of backticks when specifying the environment variable that should be substituted for the envsubst command.
GitHub issue: #3079
Removed duplicate calls to envsubst.
Default nginx listen port is now 80.
Adde markdown documentation.
* fix: Fixed some typos and wording in markdown documentation.
GitHub issue: #3079
Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>
* fix(grid):Grid service wasn't being reset
* fix(service):Fix the initial service state
Services with mode specific state differed in internal state between
initial and subsequent load. This fix address that structurally by
allows the mode to store/manage service state, but makes the
responsibility of service state central to the service.
I followed suit with how it was implemented in the v2 branch, on the 404
page I just hit the link back to the study list if we're not configured
to display it. See PR #2131
* feat(customization):Add a customization service
Update UICustomizationService to v3-stable.
Also, adds an example customization for tab colors
* moved the customization service to ui category
* feat: warn for overlapping segments
* fix: typo
* refactor mpr toggle and stack sync
* fix: wip for more general mpr
* fix: tool groups for mpr
* fix: changing of viewport id
* fix: viewport Id for the seg viewports
* fix
* update cornerstone version
* init bring v2 tag browser to v3, some small bug fixes
* moved tag browser to default extension, altered style to be more OHIF-v3-like
Co-authored-by: Michael Andersen <Michael.Andersen@rmp.uhn.ca>
* feat: add initial sop class handler for SEG
* feat: move segmentation service
* update segmentation service methods
* fix: viewport data structure
* feat: Add initial render for the DICOM SEG for each displaySet
* fix: various wrong architectural dependencies between services
* feat: initial separate SEG display in each viewport
* feat: refactore viewport action bar
* initial work for SEG hydration
* fix: various bugs regarding drag and dropping different viewports
* fix: rendering issues for multiple seg displaysets
* fix: bugs for thumbnail and hydration
* feat: fix the initial segment color
* update after rebase
* feat: initial design for the segmentation group table
* feat: initial new design for the segmentation panel
* feat: segmentation panel
* feat: make segmentation appear on all related viewports
* fix: segmentation load bug based on functional groups
* initial work for segmentation crosshairs
* fix: various stylings and functionality
* fix: various stylings for the seg panel
* fix: overflow styles
* feat: add more ui components
* feat: added segmentation config
* feat: add jump to segment
* feat: add jump to segment for DICOM SEG viewport
* fix: bugs after rebase
* feat: jump in segmentation viewport
* fix: mpr support for seg
* feat: add more icons
* feat: new icons
* feat: add new side panel
* feat: add segmentation config
* feat: add loading indicator to ohif
* feat: make hanging protocols follow matching rules for viewports
* feat: enhance drag and drop to be hanging protocol aware
* fix: mpr restore previous layout
* fix: crosshairs toggle
* fix: add auth headers to the dicom loader via dicomwebclient
* fix: bug for crosshairs toggle in mpr
* fix: seg viewport reusing old toolGroup
* feat: add loading animation with lottie
* fix: various bugs for Segmentation hydration in mpr
* feat: change outline alpha to outline opacity
* feat: loading indicator for seg viewport
* fix: various segmentation group styles
* fix: local mode for seg
* feat: add animation for the highlight
* fix: loading indicatro to show segment indices
* feat: enhance modality drop down ui
* fix: panels
* fix: download form
* fix: layout shift in loading indicator
* fix: loading indicator to have correct values
* fix: update software number
* fix: image jump between MPR and default
* fix: segmentation cleanup and cine service cleanup
* fix: segmentation toolgroup clena up
* fix: highlight interval should not trigger again
* fix: issue with multiframe sorting
* rename: change onSeriesChange to onArrowsClick
* fix: buttons for tmtv and layout shift
* fix: various bugs wrt crosshairs
* fix: crosshairs re init on reset camera
* fix: middle slice calculation different from cs middle reset camera
* fix: reset camera should reset viewport camera
* fix: loading segments in MPR mode
* fix: tmtv hp back to before
* fix: layout shift
* feat: orientation markers for volume viewport
* fix: capture for volume viewports
* fix: memory leak for back to worklist
* fix: loading bar bg color
* fix: side panel for only one panel
* fix: react select style in production
* fix: various styling for segmentation groups
* fix: various ui styles
* feat: add new segmentation config styles
* fix: hover state for segmentation item
* fix: side panel layout shift
* temp add panels
* try to fix scrollbar for thimbnail
* fix: scroll not appearing for side panels
* feat: changed styles for scrollbar
* feat: add cpu fallback warning
* fix: webworker destroy
* fix: select styles
* fix: orientation marker color and position
* fix: capture screenshot for volume viewports
* fix: hide segment visibility on mpr
* fix: reloading an already loaded seg displayset
* feat: add is equal
* fix: mpr jump to measurements
* apply review comments
* fix: optimization for the segmentation load
* fix: remove unnecessary context menu and hp service reset
* fix: segmentation service wrt brush settings
* feat: initial work for the stack synchronization
* fix: add validateDisplaySetSelectorsForNewDisplaySets to make sure drag and drop can follow requirements
* fix: various react proptypes
* fix: thumbnails for the tmtv and change default props to default params
* feat: make showing loading indicator configurable and add docs
* bump versions and add more docs
* fix demo
* update cornerstone versions
* apply review comments
* feat: add reference lines
* fix build
* fix unit tests
* add reference lines icon
* fix: e2e tests
* fix static wado config
* docs: add segmentation service docs
* fix: docker build
* fix: keep camera and bump versions
* Try re-enabling minification to fix deploy previews
Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>
* WIP
* WIP
* WIP
* fixed Bill comments on PR - https://github.com/OHIF/Viewers/pull/2979
* added series number to series filter and removed extra console.log
* changed the filter of seriesFilterKeys to studyFilterKeys
* changed the seriesInstaceUID to SeriesInstanceUID to make coerence with StudyInstanceUID
* reverted change on extension retrieveMetadataLoaderAsync and make the right change on Mode.tsx
* fixed PR comments and add small information about the filters
Co-authored-by: Thomas Forster <thomasforster@MacBookPro-Thomas.local>
* added utilities to get frameNumber from imageId and add frameNumber to per-frame instance copy
* Fix measurements' display texts on the Measurements Panel to have the correct instance number and frame number
* fixed minor React bugs (errors on console)
* fixed React's console bugs that are logged for some series that doesn't have "description"
* bug fix - multi-frame files was not loading frames correctly. It was loading Frame 1 twice, and not loading the last frame. Due to wrong frame number indexing (frame number begins with 1, not 0)
* metadata parser fix - providing default values of imagePlaneModule
* measurement SR support on multi-frame DICOM
* bug fix - jumping to the selected measurment on multi-frame DICOM
* upgrade dcmjs dependency to 2.8.1
* StudySummary component - allow "description" to be null
* make getUIDsFromImageID() method public from MetadataProvider
* imageId usage fixes to be more stable
* change the variable name to be more meaningful
* fix metaProvider importing
* for(...of) instead of for(i=0;i<length;..)
as that doesn't assume anything about the layout/design and just gets next until done.
* use Array.findIndex instead of plain for loop
* use ReferencedSOPSequence[0] - because the ReferencedSOPSequence is an array that happens to have attributes of child zero when of length 1, but you shouldn't count on that.
* DisplaySetService.getDisplaySetForSOPInstanceUID() - added optional frameNumber parameter for future usage : now they are just ignored as we are not supporting multiframe splits
* simple code refactoring
* refactoring for checking undefined values - mappedAnnotations
* remove unreachable code
* code refactoring - prefer conditional chaining
* fix how we access imageIds of viewport (StackViewport)
* add oidc logout route, button in menu
* removed old comments
* use local storage to trigger signout in other tabs
* refactored to make use useEffect
* cleaned up comments
* fix remove event listener
* moved remove leftover storage variable to beginning of usemount
Co-authored-by: Michael Andersen <Michael.Andersen@rmp.uhn.ca>
There had been a change made to make the hanging protocols
auto initialize, but that caused problems on mode init
because the couldn't specify the hanging protocols any longer.
THis change restores that, and also improves the API a little
bit by allowing the display set selectors to be specified by id
instead of positionally.
fix(hp):PR Review Comments
fix(hp):Unit test and docs
* feat: add more types to HP service
* change hp to have apply protocol
* feat: mpr initial work
* apply protocol by id
* feat: mode should be able to apply protocol directly
* fix: wrong inheritance for viewports drag and drop
* apply review comments
* fix(volume):Support volume viewing
* fix(multiframe):Display multiframe US, and multiframe PR fixes
* fix(metadataProvider):Don't call combine if frame not defined
* initial upgrade commit for tailwind
* fix: inconsistensies in button
* fix: various places with conflicts
* final fixes
* fix: dialog header color
* apply review
* feat(HP): Apply HP to display sets, fix race condition
* fix: displaySetService no event not needed (#2912)
* fix various styles and renamings
* feat: refactored hp service
* fix: use HP service event for viewport grid
* remove unnecessary doc
* fix test
* apply review comment
* fix: segmentation creation
Co-authored-by: Alireza <ar.sedghi@gmail.com>
* Prevent IntelliJ config file from being pushed to the repository
* Rename module's name to reflect the created file for a new mode
* Rename the module's name to reflect the filed created for a new extension which uses now typescript
* fix: ptDisplaySet metadata problem
* fix: typo in xhrHeader field
* fix: temporary fix for crosshairs on reload data
* fix hotkey bug for input fields
* upgrade docusarusu to stable release
* circle ci node upgrade
* cypress node upgrade
* bump node in netlify
* bump node version
* remove versioned docs
* update resources
* fix: webpack injection of plugins
* fix meaningful label for panels
* add reviews and fix cli for creation
* copy over chunks if exists in the build
* edit templates
* edit templates
* fix yarn lock
* fix(plugin):Deploy on windows is broken
Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
* feat: cs3d working stack viewport and tools (#19)
* Squashed everything
* fix weird react issue
* fix eslint / prettier stuff
* thumbnails work now with cpu rendering
* feat: use new loadImageToCanvas in cs3d
* make jump to measurement work
* fix active thumbnail
* fix measurement delete
* fix window level presets
* remove segmentation and sync groups for now
* fix the dicom pdf and dicom video
* fix cornerstone window assignment for cypress
* apply review comments
Co-authored-by: Erik <erik.sweed@gmail.com>
* feat: cs3d tools and toolGroups (#20)
* add more tools to work with cs3d mode
* fix hotkeys
* add stack manager usage for stach viewports
* add image scrollbar
* wip viewport overlay
* fix toAnnotation schema for tools
* fix the unnecessary size change that triggered resize
* hanging protocol improvement to allow unmatched errors
* study description matching for hanging protocol
* fix the displaysetOptions to work
* fix handle the active tool when a new viewport is added
* fix separate toolGroups for mode
* apply review comments
* apply review comments
* yarn lock
* feat: overlay component (#21)
* fix default displayset options
* add viewport overlay
* apply review comments
* feat: loading and orientation indicators (#22)
* add loading indicator
* add orientation marker initial work
* apply review comments
* fix: orientation markers (#23)
* finished the orientation markers
* fix various broken cypress tests
* apply review comments
* update yarn lock
* feat: re-working measurement tracking mode with cornerstone3d (#2805)
* feat: cs3d working stack viewport and tools (#19)
* Squashed everything
* fix weird react issue
* fix eslint / prettier stuff
* thumbnails work now with cpu rendering
* feat: use new loadImageToCanvas in cs3d
* make jump to measurement work
* fix active thumbnail
* fix measurement delete
* fix window level presets
* remove segmentation and sync groups for now
* fix the dicom pdf and dicom video
* fix cornerstone window assignment for cypress
* apply review comments
Co-authored-by: Erik <erik.sweed@gmail.com>
* feat: Add Measurement tracking mode with cs3D (#2789)
* feat: first render for cornerstone3d tracked viewport
* make tool active work
* wip for SR extension
* renamed dicom sr to cornerstone dicom sr
* remove cornerstone from dicom pdf and video
* move dicom sr logic to sr extension
* feat: Add hydration for the length tool
* fix SR display tool for length using cs3d
* fix default config
* fix: various bugs with sr viewport and tracking
* fix promptying to continue tracking for when SR is created
* feat: add keep trackign of unique identifiers
* fix hydration for same imageIds
* feat: Add SR toolGroup creation on modeEnter
* feat: remove the need for separate mapper for SR hydration
* add SR display for ellipse
* handle hydration of elliptical ROI tool
* remove cornerstone extension
* add arrow mapping
* feat: Add ArrowAnnotate SR display and hydration
* apply review comments
* apply review comments
* move viewport labels to the viewportData
* apply review comments
* fix: integration cypress tests with cornerstone3D and add CINE tool (#2795)
* fix: integration cypress tests with cornerstone3D
* revert to addOrUpdate as it makes more sense
* fix local drag and drop
* fix tests
* move dicomLoaderService to cornerstone extension
* fix various import bugs
* fix bug for local PT series
* fix various unit tests
* bump cs3d versions
* add angle and magnify tool
* bump dependencies to avoid broken peerDeps
* feat: add initial work for capture using cs3d
* feat: show annotations on the image capture
* feat: add svg layer export
* feat: Add CINE Tool
* feat: remove unnecessary viewport rendering for cine state changes
Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>
* docs: modify and improve documentation (#2800)
* cleanup docs versionings
* feat: Add all version explanations
* version docs for 3.0
* wip for changing docs
* wip for updated docs
* add utility module documentation
* fix demo with nohoisting of history
* add slides and video to resources
* apply review comments
* fix: drag and drop SR into SR viewport (#2803)
* update yarn lock
Co-authored-by: Erik <erik.sweed@gmail.com>
* update pathnames to match v3-stable
* update the e2e pathname
* fix: various bugs with regard to tracking workflow (#2811)
* fix: various issues with measurement panel
* fix: update default tool style for annotations
* fix: annotatoin label getting removed
* feat: Add backward compatibility for SR hydration with legacy cornerstone
* fix: cursors and ellipse ROI max style
* fix: ArrowAnnotate SRDisplay
* apply review comments
* bump package versions
* fix: bugin rehydration of SR
* fix: e2e tests
* fix active viewport thickness and arrowTool ui
* add readme for measurement tracking
* use uploaded image for readme
* add back images
* try to fix e2e test
* fix: window level presets hotkeys
* Update README.md
* update yarn lock
* feat: volume api and TMTV mode (#2817)
* feat: volumeAPI and TMTV mode
* feat: use cs3d cache service to obtain viewportData
* wip for volume api
* wip: fusion viewport
* feat: add blend mode option
* wip for image scrollbar
* fix drag and drop thumbnail
* wip for image scrollbar for voluems
* fix: element mismatch bug for scroll
* feat: Add image scrollbar to volumes
* feat: add syncGroups to volume api
* feat: add tmtv mode initial setup
* feat: add initial image options for the stack viewports
* feat: Add custom load strategy for volume viewports via HP
* apply review comments
fix: Jump presets cs3d (#2812)
* feat: Add JumpPreset to OHIF for Cornerstone3D
* fix: accessing viewport service from servicesManager
feat: volume API and TMTV mode (#2814)
* fix: do not display overlays on mip viewports
* feat: add optional disableCommands for toggle buttons
* fix: toggleCrossharis
* feat: config the crosshairs
* feat: add PetSUV Panel for changing metadata
* feat: initial work for the rectangleROIThreshold panel
* wip: measurement service
* roi threshold working
* feat: Add displayText to segmentations
* feat: add remove segmentation
* feat: add csv export
* feat: add RT export for annotations in tmtv mode
* fix: fusion to use pt in tmtv mode and measuremet mappings
* fix: various bugs
* apply review comments
* apply review comments
* feat: add fusion color maps
* add readme to tmtv mode
* Update README.md
* fix: try to fix build
* fix unit tests
* Update README.md
* feat: add about to the panel
* fix: changing strategy in roi panel
* apply review comments
* update package versions
* wip for stackPrefetch
* fix: cornerstone3d hydration and renaming (#2818)
* update readme
* renamed cornerstone extension
* wip for renaming cornerstone3D variables
* wip for renaming cornerstone3D variables
* wip for fixing bugs for SR viewport
* fix: jumpToMeasurement and initial label after hydration
* fix: fileName capitalization
* feat: use the new prefetch stack in the cs3d (#2820)
* feat: use the new prefetch stack in the cs3d
* use viewport scroll api for stack viewport
* fix cine stop when scrollbar changes
* feat: use new prefetch events
* fix loading state to not show repeatedly
* fix: various bugs for tmtv mode thresholding and new icons (#2823)
* feat: make tmtv mode available in worklist
* feat: add new icons for tmtv mode
* feat: add fusion color icon
* fix: parallel scale calculation
* fix: bump Cornerstone to get large image support working
* fix: Fix issues with CPU viewport flipping, including config files
* fix: bump cornerstone to fix magnify tool
* fix: Bump Cornerstone version to fix resetCamera issue in StackViewport
* ci: Add _headers file to enable CORS headers for Netlify Drag/Drop deploys
* fix: WADO-URI was not working. PET Metadata was coming from the wrong place. Fixed some minor React errors
* feat(OHIF):Allow modes and extensions to be added after commpile time. (#2838)
Also works with the compile time add that the existing cli uses, so that both build types work.
Eric and I agreed this doesn't change existing functionality, but is almost entirely build issues/fixes.
* bump: dependency versions to fix hydration bugs (#2848)
* bump: dcmjs version to fix hydration bugs
* try to fix tests
* bump dependency versions
Co-authored-by: Alireza <ar.sedghi@gmail.com>
Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
* fix ohif-cli cosmetic changes for help description
* refact code review fix main command name
* fix extension template fix extension-default package version
* feat: Add initial cli tool structure
* feat: add copying template files
* feat: Add mode template and command
* feat: Add readme template generation
* feat: Add documentation to extension template
* feat: Enhance documentation of the template mode
* fix: cli module type
* feat: Add config-based mode and extension registration (#2660)
* feat: Add ohif cli add/remove extension/mode (#2661)
* Basic working CLI for add-extension and remove-extension
* Basic cli for add/remove extension/mode, lots more to do.
* Cleanup and harden]
* feat: Add list of tasks to add-mode
Co-authored-by: Alireza <ar.sedghi@gmail.com>
* feat: Add git initialization for the mode or extension template (#2662)
* fix: package json file to include templates
* feat: Add git initialization for the mode or extension template
* feat: Add more checks of git and target dir
* feat: refactore library utilities
* feat: Add the list command to print extensions and modes (#2664)
* feat: Add the list command to print extensions and modes
* Add todo
* Feat/ohif cli validation + auto install (#2671)
* WIP
* Working mode keyword verification
* Validation
* auto install extensions based on modes
* WIP remove unused extensions on removeMove
* Working add-mode, remove-mode automatic extension management.
* If extension is in used by a mode, don't allow the CLI to uninstall it
* Cleanup addExtension
* cleanup removeExtension and addMode
* Cleanup removeMode
* Update existing extensions with the needed keywords/peer deps
* Fix broken config
* Feat/cli search (#2677)
* feat: refactor pretty print for console
* feat: add search for modes and extensions
* fix: ugly colors
* Feat/ohif cli error handling publishing (#2679)
* WIP
* fix: webpack imports
* wip
* fix: react router dom private routes
* from last commit
* wip
* fix: webpack prod builds
* WIP
* Working regsitration with new IDs
* Stable
Co-authored-by: Alireza <ar.sedghi@gmail.com>
* verify extensions when constructing modes. (#2681)
* verify extensions when constructing modes.
* Add version to unit tests so it conforms to schema
* Update ohif utils exposed via @ohif/core
* Fix import
* fix tests
* feat: ohif-cli link local modes/extensions for development (#2682)
* feat: enable cli to work with project root
* feat: add initial link package
* feat: add link and unlink extension
* feat: add link and unlink mode
* erro handling for link-package
* feat: add comment on ohif-cli linking for development (#2686)
* Docs/ohif cli (#2687)
* feat: Add documentation for templates
* feat: Add more documentation
* Fix/core publish (#2685)
* versions
* wip
* remove webpack clean output
* fix publish
* use next as dist tag for v3 for now
* fix webpack pro recipe for output
* fix: lerna publish next
* fix(cli): fix issues when trying to link an extension or a mode (#2725)
The generated package.json doesn't contain keywords property which is
required by the linkPackage function. The module apth wasn't correclty
handled too, and when there is no pluginOptions, it fails while reading
the file or while generating a default configuration.
* make dicom pdf and video work after cli merge
* add axios dependency
* comment out the chdir for now
* create id and version based on user inputs
* customizable path for extension and modes
* fix template to make the template mode load
* fix the questions to loop if path is not desirable
* fix templates
* correct package json order
* unify the package creation for extension and mode
* bump versions for each package
* bump extension versions to 3.0
* add gitignore to templates
* fix version requirements when ^
* update docs
* update docs and fix tests
* try to fix the tests
* bump node version
* remove the version from extensions
* remove the version from modes
* remove version from extensionManager
* fix eslint
* revert husky version
* fix eslint
* fix node version for new eslint
* fix documentatoin removing version
* fix cicle ci image version
* fix circle ci node image
* fix circle ci node image
* add back the video and pdf
Co-authored-by: Matthis Duclos <matthis.duclos@gmail.com>
Co-authored-by: James A. Petts <jamesapetts@gmail.com>
* feat(OHIFv3):Add a video viewport
* Fixed a couple of viewing issues
* fix(OHIF):If not all instances are used by a given provider, then continue to add items
* Added video data
* Add a basic e2e test for video display
* Adding a screen shot as requested
* wip on storybook as a replacement for using UI components in docusaurus, since it causes too many problems
* fix: storybook webpack config
* feat: add more stories
* feat: add more stories
* feat: add more stories
* feat: fix logo and babel runtime error
* feat: move to mdx docs for ui
* feat: enhanced mdx for header and styles
* feat: Add button usecases
* feat: Add buttonGroup docs
* feat: Add docs and use case to cine and contex menu
* feat: fix decorators
* feat: add header and dropdown docs
* feat: add Icon and input docs
* feat: add more docs
* feat: add more stories
* fix: feedback section
* feat: Add doc page
* feat: Add typography and color stories
* yarn lock
* add analytics to v3-ui
* new banner image
* new viewport component
* update review comments
This change wraps the E2E test data into a github repository, which is then included in the test builds as static data.
That makes running the e2e tests as simple as:
yarn test:e2e:server
yarn test:e2e
without any need to have docker etc installed/running.
This is the initial addition of the config point settings to allow run time loading of GUI settings via "theme" files/parameters.
The intent is to add an example PR that shows when to use config point, how to configure it, write documentation for it etc.
* fix(OHIFv3):Overlays were broken.
Adds a retrieveBulkData to elements containing BulkDataURI so that
anyone display the data can retrieve the required information.
* fix(OHIFv3):Added a call in the wrong spot, removed it.
* docs(OHIFv3):Added some documentation as requested
* feat: update to prerelease of WADO Image Loader, add copy plugin to pull dist/dynamic-import into OHIF
* fix: Set empty public path
* perf: Add webpackPrefetch tags to lazy loaded components
* Switch to using webpack alias to use dynamic import version of WADO Image Loader
* fix lockfile
* prevent polyfilling zlib
* bump to wado image loader 4.0.3 with fix for public path
* Rebased to have just the static view changes
* Changes based on the PR
* Couple more changes for the PR
* Removed an extraneous log
* Fix the study worklist display when returning to the page
* Added some documentation on the static wado data source setup, and a
bounds check change on the Queue test which was failing
* PR updates - change the undefined study description to '' and remove the aws deploy
* Fixed the e2e tests to actually pass/fail correctly on actual results
* feat: Add OpenID Connect support, speed up docker rebuilds
* fix: Switch Google Cloud API URL to v1
* chore: Remove redux-oidc and use our own components instead
